Terraform Validator is not an officially supported Google product; it is a library for conversion of Terraform plan data to CAI Assets. If you have been using terraform-validator directly in the past, we recommend migrating to `gcloud beta terraform vet`.
I found a handwritten data source in the folder location for handwritten resources - I wanted to correct this
I also found a data source test file that was named in a way that broke conventions
Also, some handwritten tests were in an incorrect location so they weren't copied into the downstream correctly
mmv1/third_party/terraform/examples/*_test.go moved to mmv1/third_party/terraform/tests
As a result of # 3 above, this PR introduces two new tests to the downstreams that I didn't write:
TestAccCertificateManagerDnsAuthorization_update
TestAccNetworkServicesEdgeCacheKeyset_update
If this PR is for Terraform, I acknowledge that I have:
[x] Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
[x] Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
[x] Ran relevant acceptance tests using my own Google Cloud project and credentials (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
Small, nit-picky PR:
mmv1/third_party/terraform/examples/*_test.gomoved tommv1/third_party/terraform/testsAs a result of # 3 above, this PR introduces two new tests to the downstreams that I didn't write:
TestAccCertificateManagerDnsAuthorization_updateTestAccNetworkServicesEdgeCacheKeyset_updateIf this PR is for Terraform, I acknowledge that I have:
Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).Generated Terraform providers, and ranmake testandmake lintin the generated providers to ensure it passes unit and linter tests.Ran relevant acceptance tests using my own Google Cloud project and credentials (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).Release Note Template for Downstream PRs (will be copied)
Derived from https://github.com/GoogleCloudPlatform/magic-modules/pull/7505