Terraform Validator is not an officially supported Google product; it is a library for conversion of Terraform plan data to CAI Assets. If you have been using terraform-validator directly in the past, we recommend migrating to `gcloud beta terraform vet`.
If this PR is for Terraform, I acknowledge that I have:
[X] Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
[X] Generated Terraform, and ran make test and make lint to ensure it passes unit and linter tests.
[X] Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
[x] Ran relevant acceptance tests (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
Note: unit tests seem to be broken. I was able to run make test for generated code as follows:
$ make test
$ make fmt
$ make test
...
google/resource_bigtable_app_profile.go:468:9: undefined: bigtableadmin
google/resource_compute_subnetwork.go:39:22: undefined: cidr
...
$ rm google/resource_bigtable_app_profile.go google/resource_bigtable_app_profile_test.go google/resource_compute_subnetwork.go google/resource_compute_subnetwork_test.go
$ sed -i '/resourceBigtableAppProfile/d' google/provider.go
$ sed -i '/resourceComputeSubnetwork/d' google/provider.go
$ make test
Release notes
container: added support for `advanced_machine_features.threads_per_core`
Add GKE support for threads_per_core option
Related issue: https://github.com/hashicorp/terraform-provider-google/issues/11588
If this PR is for Terraform, I acknowledge that I have:
make test
andmake lint
to ensure it passes unit and linter tests.Note: unit tests seem to be broken. I was able to run
make test
for generated code as follows:Release notes
Derived from https://github.com/GoogleCloudPlatform/magic-modules/pull/6808