GoogleCloudPlatform / terraform-validator

Terraform Validator is not an officially supported Google product; it is a library for conversion of Terraform plan data to CAI Assets. If you have been using terraform-validator directly in the past, we recommend migrating to `gcloud beta terraform vet`.
https://cloud.google.com/docs/terraform/policy-validation
Apache License 2.0
437 stars 93 forks source link

Add GKE support for threads_per_core option #1493

Closed modular-magician closed 1 year ago

modular-magician commented 1 year ago

Add GKE support for threads_per_core option

Related issue: https://github.com/hashicorp/terraform-provider-google/issues/11588

If this PR is for Terraform, I acknowledge that I have:

Note: unit tests seem to be broken. I was able to run make test for generated code as follows:

$ make test
$ make fmt
$ make test
...
google/resource_bigtable_app_profile.go:468:9: undefined: bigtableadmin
google/resource_compute_subnetwork.go:39:22: undefined: cidr
...
$ rm google/resource_bigtable_app_profile.go google/resource_bigtable_app_profile_test.go google/resource_compute_subnetwork.go google/resource_compute_subnetwork_test.go
$ sed -i '/resourceBigtableAppProfile/d' google/provider.go
$ sed -i '/resourceComputeSubnetwork/d' google/provider.go
$ make test

Release notes

container: added support for `advanced_machine_features.threads_per_core`

Derived from https://github.com/GoogleCloudPlatform/magic-modules/pull/6808