GoogleCloudPlatform / terraform-validator

Terraform Validator is not an officially supported Google product; it is a library for conversion of Terraform plan data to CAI Assets. If you have been using terraform-validator directly in the past, we recommend migrating to `gcloud beta terraform vet`.
https://cloud.google.com/docs/terraform/policy-validation
Apache License 2.0
438 stars 93 forks source link

Update TestAccBillingBudget_budgetFilterProjectsOrdering to avoid access issues #1516

Closed modular-magician closed 1 year ago

modular-magician commented 1 year ago

With the billing accounts/permissions changing for our test projects, we've missed a case here with TestAccBillingBudget_budgetFilterProjectsOrdering. This test tries to create new projects (requires a billing account that can be charged), and update the budget config (requires billing admin access on the billing account) using the "master" billing account. We actually don't have a billing account that can support both of these operations, so instead this fix avoids the need to create new projects.

My first attempt here is to use fake project ids, but if that fails, we can potentially use existing project ids, or create projects using a different billing account.

If this PR is for Terraform, I acknowledge that I have:

Release Note Template for Downstream PRs (will be copied)

Derived from https://github.com/GoogleCloudPlatform/magic-modules/pull/7553