Terraform Validator is not an officially supported Google product; it is a library for conversion of Terraform plan data to CAI Assets. If you have been using terraform-validator directly in the past, we recommend migrating to `gcloud beta terraform vet`.
With the billing accounts/permissions changing for our test projects, we've missed a case here with TestAccBillingBudget_budgetFilterProjectsOrdering. This test tries to create new projects (requires a billing account that can be charged), and update the budget config (requires billing admin access on the billing account) using the "master" billing account. We actually don't have a billing account that can support both of these operations, so instead this fix avoids the need to create new projects.
My first attempt here is to use fake project ids, but if that fails, we can potentially use existing project ids, or create projects using a different billing account.
If this PR is for Terraform, I acknowledge that I have:
[x] Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
[x] Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
[x] Ran relevant acceptance tests using my own Google Cloud project and credentials (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
With the billing accounts/permissions changing for our test projects, we've missed a case here with
TestAccBillingBudget_budgetFilterProjectsOrdering
. This test tries to create new projects (requires a billing account that can be charged), and update the budget config (requires billing admin access on the billing account) using the "master" billing account. We actually don't have a billing account that can support both of these operations, so instead this fix avoids the need to create new projects.My first attempt here is to use fake project ids, but if that fails, we can potentially use existing project ids, or create projects using a different billing account.
If this PR is for Terraform, I acknowledge that I have:
make test
andmake lint
in the generated providers to ensure it passes unit and linter tests.Release Note Template for Downstream PRs (will be copied)
Derived from https://github.com/GoogleCloudPlatform/magic-modules/pull/7553