GoogleCloudPlatform / terraform-validator

Terraform Validator is not an officially supported Google product; it is a library for conversion of Terraform plan data to CAI Assets. If you have been using terraform-validator directly in the past, we recommend migrating to `gcloud beta terraform vet`.
https://cloud.google.com/docs/terraform/policy-validation
Apache License 2.0
437 stars 93 forks source link

Remove activesupport array extensions #1519

Closed modular-magician closed 1 year ago

modular-magician commented 1 year ago

ActiveSupport is a part of Ruby on Rails that we use for string processing in MMv1. While it can make reasonable assumptions about translating between pluralisms/acronyms/cases, it ultimately makes our generated code less predictable.

ActiveSupport methods are added to preexisting types, extending them with new methods. That can make what is/isn't coming from a library unpredictable. This removes the cases where arrays were extended, with .to_sentence. I've shifted the affected pieces of documentation to present a list rather than work field names in naturally.

If this PR is for Terraform, I acknowledge that I have:

Release Note Template for Downstream PRs (will be copied)

Derived from https://github.com/GoogleCloudPlatform/magic-modules/pull/7579