GoogleCloudPlatform / terraform-validator

Terraform Validator is not an officially supported Google product; it is a library for conversion of Terraform plan data to CAI Assets. If you have been using terraform-validator directly in the past, we recommend migrating to `gcloud beta terraform vet`.
https://cloud.google.com/docs/terraform/policy-validation
Apache License 2.0
438 stars 93 forks source link

Allows empty value and sets default value for maxRetries of cloud run job #1542

Closed modular-magician closed 1 year ago

modular-magician commented 1 year ago

Fixes https://github.com/hashicorp/terraform-provider-google/issues/13747.

Got compiling error when running tests in downstream repos, which was not caused by this change.

If this PR is for Terraform, I acknowledge that I have:

Release Note Template for Downstream PRs (will be copied)

cloudrunv2: set a default value of 3 for `max_retries` in `google_cloud_run_v2_job`. This should match the API's existing default, but may show a diff at plan time
cloudrunv2: fixed the bug where setting `max_retries` to 0 in `google_cloud_run_v2_job` was not respected.

Derived from https://github.com/GoogleCloudPlatform/magic-modules/pull/7425