GoogleCloudPlatform / terraform-validator

Terraform Validator is not an officially supported Google product; it is a library for conversion of Terraform plan data to CAI Assets. If you have been using terraform-validator directly in the past, we recommend migrating to `gcloud beta terraform vet`.
https://cloud.google.com/docs/terraform/policy-validation
Apache License 2.0
437 stars 93 forks source link

Check batching attributes in framework defaults #1547

Closed modular-magician closed 1 year ago

modular-magician commented 1 year ago

Fixes https://github.com/hashicorp/terraform-provider-google/issues/14217

I copied this invocation from one of the DNS resources- it's frustrating that the framework forces us to handwrite this when the schema is sitting right there.

I don't entirely trust the defaulting logic so this likely isn't the final PR for 4.60.2, but I wanted to send this before digging in more.

If this PR is for Terraform, I acknowledge that I have:

Release Note Template for Downstream PRs (will be copied)

provider: fixed an issue where the provider crashed when "batching" was set in `4.60.0`/`4.60.1`

Derived from https://github.com/GoogleCloudPlatform/magic-modules/pull/7642