Terraform Validator is not an officially supported Google product; it is a library for conversion of Terraform plan data to CAI Assets. If you have been using terraform-validator directly in the past, we recommend migrating to `gcloud beta terraform vet`.
In the past these defaults would be set on the schema, however now that they can't be we have to check if they're set and, if not, set them to the defaults manually.
We have 2 functions MultiEnvSearch which assumes its a string and MultiEnvDefault which returns an interface and allows a default value to be set in the case the env var isn't set.
All of these were using MultiEnvSearch - most are strings except USER_PROJECT_OVERRIDE - in this case we need it to be a bool.
On top of that we were checking d.Get() == "", but in this case d.Get was false so we have to check d.GetOk, from here we need to make it a bool rather than a string, so added in the ParseBool.
I checked the rest of these defaults that moved from the schema to here and they indeed are all strings, so I put the logic on this individual case rather than in the MultiEnvDefault function
If this PR is for Terraform, I acknowledge that I have:
[ ] Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
[ ] Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
[ ] Ran relevant acceptance tests using my own Google Cloud project and credentials (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
Fixes https://github.com/hashicorp/terraform-provider-google/issues/14201
In the past these defaults would be set on the schema, however now that they can't be we have to check if they're set and, if not, set them to the defaults manually.
We have 2 functions
MultiEnvSearchwhich assumes its a string andMultiEnvDefaultwhich returns an interface and allows a default value to be set in the case the env var isn't set.All of these were using
MultiEnvSearch- most are strings exceptUSER_PROJECT_OVERRIDE- in this case we need it to be a bool.On top of that we were checking
d.Get() == "", but in this cased.Getwasfalseso we have to checkd.GetOk, from here we need to make it a bool rather than a string, so added in the ParseBool.I checked the rest of these defaults that moved from the schema to here and they indeed are all strings, so I put the logic on this individual case rather than in the
MultiEnvDefaultfunctionIf this PR is for Terraform, I acknowledge that I have:
make testandmake lintin the generated providers to ensure it passes unit and linter tests.Release Note Template for Downstream PRs (will be copied)
Derived from https://github.com/GoogleCloudPlatform/magic-modules/pull/7644