Add a tab bar with proper navigation and grid data placeholder.

sultan-duisenbay commented 1 year ago

Add a proper navigation to a tab bar and grid data placeholder. Improved the comments and addressed some nits.

Major changes

Renamed dashboard-summary => testgrid-dashboard-summary
Created a new testgrid-data-content component which will render a dashboard summary or grid data based on which tab is clicked on the tab bar.
Added a testgrid-grid-display component responsible for fetching the grid data and rendering it
Clicking on any tab in the tab bar will also change the URL pathname to /{dashboard} or /{dashboard}/{tab}
Going to a particular URL will now highlight the correct tab in the tab bar

In the next episode:

Add the tests and update storybooks for this change

sultan-duisenbay commented 1 year ago

Added the tests just now

google-oss-prow[bot] commented 1 year ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: michelle192837, sultan-duisenbay

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/GoogleCloudPlatform/testgrid/blob/master/OWNERS)~~ [michelle192837,sultan-duisenbay] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment

GoogleCloudPlatform / testgrid

Add a tab bar with proper navigation and grid data placeholder. #1189

Major changes