search

GoogleCloudPlatform / testgrid

Apache License 2.0
194 stars 68 forks source link

WIP: Add a DashboardResource #1206

Closed ankur12-1610 closed 1 year ago

ankur12-1610 commented 1 year ago

This PR adds a new resource namely DashboardResource which is created in order to add reference of individual dashboards to their respective dashboard groups.

Although there is one ambiguity, for dashboard groups, should the DashboardGroupResource (which will be the new resource created) consist of a list of dashboards?

Do we really need a new resource for dashboard groups?

I'm thinking of a way in which iterating over dashboards and then storing values in a map in the frontend can be done as well, not sure if it is viable.

google-oss-prow[bot] commented 1 year ago

Hi @ankur12-1610. Thanks for your PR.

I'm waiting for a GoogleCloudPlatform member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
sultan-duisenbay commented 1 year ago

Hi Ankur and thanks for your PR. We are in the process of discussing the overall API structure and endpoints. Will keep you posted

ankur12-1610 commented 1 year ago

Hi Ankur and thanks for your PR. We are in the process of discussing the overall API structure and endpoints. Will keep you posted

Hey sure, I'm still working on the PR though. haven't tested it yet :sweat_smile:

google-oss-prow[bot] commented 1 year ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ankur12-1610, chases2

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/GoogleCloudPlatform/testgrid/blob/master/OWNERS)~~ [chases2] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
google-oss-prow[bot] commented 1 year ago

@ankur12-1610: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
test-testgrid-all 164b8127511ee1d95aff4e3d02e9f47028b6a6d5 link true /test test-testgrid-all
Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
sultan-duisenbay commented 1 year ago

@ankur12-1610 , if the protos are changed in any way, please run bazel run //hack:update-protos command. Thanks!

sultan-duisenbay commented 1 year ago

Covered by in #1215