GoogleCloudPlatform / testgrid

Apache License 2.0
194 stars 68 forks source link

Address grid component comments. #1208

Closed michelle192837 closed 1 year ago

michelle192837 commented 1 year ago

Followup to comments on #1192 . (Some already addressed by #1207).

For row-id vs. row-name, I realized that given how the component renders, it's less of an ID and more of a display name thing, so I think 'name' feels more accurate? Happy to roll that part back though.

Storybook: 8noJSJdFQSab6EU Local: 54vtgxKFZUwx2Dk

google-oss-prow[bot] commented 1 year ago

Skipping CI for Draft Pull Request. If you want CI signal for your change, please convert it to an actual PR. You can still manually trigger a test run with /test all

google-oss-prow[bot] commented 1 year ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: michelle192837, sultan-duisenbay

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/GoogleCloudPlatform/testgrid/blob/master/OWNERS)~~ [michelle192837,sultan-duisenbay] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
michelle192837 commented 1 year ago

Thanks! Changes made, and verified the Storybook stories and local run still work ^^

michelle192837 commented 1 year ago

/hold cancel