search

GoogleCloudPlatform / testgrid

Apache License 2.0
194 stars 68 forks source link

Remove empty results from truncation column. #1217

Closed michelle192837 closed 1 year ago

michelle192837 commented 1 year ago

The unit tests can imply otherwise, but when we inflate a column for a grid we actually have a cell for each row, which may have a real status or may be empty. Only replace non-empty cells with the truncation warning, so empty rows can be dropped after truncation.

google-oss-prow[bot] commented 1 year ago

Skipping CI for Draft Pull Request. If you want CI signal for your change, please convert it to an actual PR. You can still manually trigger a test run with /test all

google-oss-prow[bot] commented 1 year ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: michelle192837, sultan-duisenbay

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/GoogleCloudPlatform/testgrid/blob/master/OWNERS)~~ [michelle192837,sultan-duisenbay] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
michelle192837 commented 1 year ago

Thanks!

/hold cancel