search

GoogleCloudPlatform / testgrid

Apache License 2.0
194 stars 68 forks source link

Fix tab links #1218

Closed sultan-duisenbay closed 1 year ago

sultan-duisenbay commented 1 year ago

Make sure that clicking on tab links doesn't reload the whole page - and more closely resembles the current prod UI.

Also, there was a small bug when going to a tab from summary and going back, the view was not updated properly. this is fixed now

michelle192837 commented 1 year ago

Thanks for fixing! ^^ Is it possible to add a unit test checking the tab-switching behavior?

google-oss-prow[bot] commented 1 year ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: michelle192837, sultan-duisenbay

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/GoogleCloudPlatform/testgrid/blob/master/OWNERS)~~ [michelle192837,sultan-duisenbay] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
sultan-duisenbay commented 1 year ago

/hold

(re: unit test comment)

@michelle192837 I tried mimicking the popstate event but wasn't able to get it to work. I will add a TODO if that's OK

michelle192837 commented 1 year ago

TODO sounds good for now ^^

sultan-duisenbay commented 1 year ago

/hold cancel