search

GoogleCloudPlatform / testgrid

Apache License 2.0
194 stars 68 forks source link

Create failing tests dropdown component in dashboard tab summary #1221

Closed bryan-lou closed 1 year ago

google-oss-prow[bot] commented 1 year ago

Hi @bryan-lou. Thanks for your PR.

I'm waiting for a GoogleCloudPlatform member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
michelle192837 commented 1 year ago

Thanks for the PR, Bryan! Left comments here and there. The major one is to finalize a separate element for the table data and embed it into tab-summary element.

In addition to this, would be great to add it to tab summary stories - make some of them have failuresSummary. Also add the test cases for tab summary

+1 to Sultan's comments in general (thanks Sultan!). Only other note I'd add is, it'd be nice to take advantage of an existing table web component if one exists (ideally one that already includes sorting by particular headers). I didn't find one in the Material web components, but there should be some that exist already.

sultan-duisenbay commented 1 year ago

/ok-to-test

google-oss-prow[bot] commented 1 year ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bryan-lou, sultan-duisenbay

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/GoogleCloudPlatform/testgrid/blob/master/OWNERS)~~ [sultan-duisenbay] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
sultan-duisenbay commented 1 year ago

/hold cancel

sultan-duisenbay commented 1 year ago

/lgtm