GoogleCloudPlatform / testgrid

Apache License 2.0
194 stars 68 forks source link

Add healthiness report dropdown to dashboard summary tab #1224

Closed bryan-lou closed 1 year ago

google-oss-prow[bot] commented 1 year ago

Hi @bryan-lou. Thanks for your PR.

I'm waiting for a GoogleCloudPlatform member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
bryan-lou commented 1 year ago

Do you have a screenshot or test to show what the healthiness report looks like?

Hi @chases2 , here are few screenshots which show what they look like in the dashboard summary

Screenshot 2023-06-20 at 3 04 23 PM Screenshot 2023-06-20 at 3 04 39 PM Screenshot 2023-06-20 at 3 08 19 PM
chases2 commented 1 year ago

Looks good! Would love to see some simple Jasmine tests that assert that data in the structure is displayed in the component. You may also consider creating a storybook entry for this component in a follow-up PR.

/ok-to-test /lgtm

google-oss-prow[bot] commented 1 year ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bryan-lou, sultan-duisenbay

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/GoogleCloudPlatform/testgrid/blob/master/OWNERS)~~ [sultan-duisenbay] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment