GoogleCloudPlatform / testgrid

Apache License 2.0
194 stars 68 forks source link

WIP: Improve frontend code structure #1228

Closed sultan-duisenbay closed 9 months ago

sultan-duisenbay commented 1 year ago

We are creating many components, so it's time to structurize those elements.

Moved al routers to navigation dir, all grid components to grid dir, all dashboard components to dashboard dir and group related components to group dir.

google-oss-prow[bot] commented 1 year ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sultan-duisenbay

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/GoogleCloudPlatform/testgrid/blob/master/OWNERS)~~ [sultan-duisenbay] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
google-oss-prow[bot] commented 1 year ago

@sultan-duisenbay: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
test-testgrid-npm b25029d56be69f9bd87a3f2598c772c926d5e2d0 link true /test test-testgrid-npm
Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
michelle192837 commented 1 year ago

This is great, thanks! I think it should be separated from the other commit though, or indicate this is blocked by another PR.