search

GoogleCloudPlatform / testgrid

Apache License 2.0
194 stars 68 forks source link

Alert stale tab when no rows exist. #1232

Closed michelle192837 closed 1 year ago

michelle192837 commented 1 year ago

It's possible to have a grid with a column (see https://github.com/GoogleCloudPlatform/testgrid/blob/6ad903765c1a60491ea661d268780aa0e0de71ea/pkg/tabulator/tabstate.go#L445, which keeps a column if the grid would otherwise be empty) but no rows. This is fine, but the stale alert doesn't account for this at the moment. Update it to alert when no rows exist, in addition to the other reasons a tab might be stale.

google-oss-prow[bot] commented 1 year ago

Skipping CI for Draft Pull Request. If you want CI signal for your change, please convert it to an actual PR. You can still manually trigger a test run with /test all

google-oss-prow[bot] commented 1 year ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: michelle192837, sultan-duisenbay

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/GoogleCloudPlatform/testgrid/blob/master/OWNERS)~~ [michelle192837,sultan-duisenbay] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
michelle192837 commented 1 year ago

Thanks! /hold cancel