search

GoogleCloudPlatform / testgrid

Apache License 2.0
194 stars 68 forks source link

Add new pod monitors for metrics on GMP. #1236

Closed michelle192837 closed 1 year ago

michelle192837 commented 1 year ago

Following https://cloud.google.com/stackdriver/docs/solutions/gke/gmp-migration to migrate us to managed prometheus so our metrics work again ^^

google-oss-prow[bot] commented 1 year ago

Skipping CI for Draft Pull Request. If you want CI signal for your change, please convert it to an actual PR. You can still manually trigger a test run with /test all

michelle192837 commented 1 year ago

/hold

Actually, since it's just adding new resources, no reason I can't add canary and prod in the same PR.

michelle192837 commented 1 year ago

/hold cancel

google-oss-prow[bot] commented 1 year ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: michelle192837, sultan-duisenbay

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/GoogleCloudPlatform/testgrid/blob/master/OWNERS)~~ [michelle192837,sultan-duisenbay] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment