GoogleCloudPlatform / testgrid

Apache License 2.0
193 stars 68 forks source link

Extract grouping ID based on configurations #1242

Closed bryan-lou closed 1 year ago

bryan-lou commented 1 year ago

Extract the group ID based on primary grouping option or fallback to a default grouping by invocation

google-oss-prow[bot] commented 1 year ago

Hi @bryan-lou. Thanks for your PR.

I'm waiting for a GoogleCloudPlatform member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
bryan-lou commented 1 year ago

Largely LGTM with a couple of nits, please address those and it's good to be merged!

/hold

Addressed comments

sultan-duisenbay commented 1 year ago

/ok-to-test

sultan-duisenbay commented 1 year ago

/lint

sultan-duisenbay commented 1 year ago

/retest

bryan-lou commented 1 year ago

/retest

google-oss-prow[bot] commented 1 year ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bryan-lou, sultan-duisenbay

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/GoogleCloudPlatform/testgrid/blob/master/OWNERS)~~ [sultan-duisenbay] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
sultan-duisenbay commented 1 year ago

/hold cancel