Closed bryan-lou closed 1 year ago
Hi @bryan-lou. Thanks for your PR.
I'm waiting for a GoogleCloudPlatform member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test
on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.
Once the patch is verified, the new status will be reflected by the ok-to-test
label.
I understand the commands that are listed here.
Largely LGTM with a couple of nits, please address those and it's good to be merged!
/hold
Addressed comments
/ok-to-test
/lint
/retest
/retest
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: bryan-lou, sultan-duisenbay
The full list of commands accepted by this bot can be found here.
The pull request process is described here
/hold cancel
Extract the group ID based on primary grouping option or fallback to a default grouping by invocation