search

GoogleCloudPlatform / testgrid

Apache License 2.0
193 stars 68 forks source link

Enable custom target result status #1248

Closed sultan-duisenbay closed 1 year ago

sultan-duisenbay commented 1 year ago

We are just reusing the functionality within updater package, which is already unit tested

sultan-duisenbay commented 1 year ago

This looks good, but I think this should include where we're adding customTargetStatus().

Will do

google-oss-prow[bot] commented 1 year ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chases2, sultan-duisenbay

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/GoogleCloudPlatform/testgrid/blob/master/OWNERS)~~ [chases2,sultan-duisenbay] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment