search

GoogleCloudPlatform / testgrid

Apache License 2.0
193 stars 68 forks source link

Add properties, and a few stats to testsuite, and status to testcase. #1252

Closed minzhuogoogle closed 11 months ago

minzhuogoogle commented 11 months ago

Add properties for testsuite, along with a few other fields.

Properties, disabled, errors, and status are set for testsuite. And properties have critical information related with testsuite as name in the majority of junit files. For stats disabled, skipped and etc are numbers needed to be extracted too.

google-oss-prow[bot] commented 11 months ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: minzhuogoogle Once this PR has been reviewed and has the lgtm label, please assign chases2 for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/GoogleCloudPlatform/testgrid/blob/master/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
google-oss-prow[bot] commented 11 months ago

Hi @minzhuogoogle. Thanks for your PR.

I'm waiting for a GoogleCloudPlatform member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
michelle192837 commented 11 months ago

/ok-to-test

michelle192837 commented 11 months ago

/lint

minzhuogoogle commented 11 months ago

/test test-testgrid-all

michelle192837 commented 11 months ago

Thanks! New fields look good, I think another couple test cases (or extensions of the existing ones in TestParse() in junit_test.go) with the new fields will be good. 👍

Ah, and in addition to unit tests, if you can squash the commits down into 1 commit that would be great. ^^