GoogleCloudPlatform / testgrid

Apache License 2.0
198 stars 68 forks source link

Update junit.go to allow more data to be extracted. #1259

Closed minzhuogoogle closed 1 year ago

minzhuogoogle commented 1 year ago

Properties is available for testsuite, not for result in all prow jobs I checked. For now, add properties to Suite only for the safety purpose. modified: junit.go modified: junit_test.go

google-oss-prow[bot] commented 1 year ago

Hi @minzhuogoogle. Thanks for your PR.

I'm waiting for a GoogleCloudPlatform member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
minzhuogoogle commented 1 year ago

/retest

google-oss-prow[bot] commented 1 year ago

@minzhuogoogle: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to [this](https://github.com/GoogleCloudPlatform/testgrid/pull/1259#issuecomment-1740181790): >/retest Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
minzhuogoogle commented 1 year ago

/ok-to-test

minzhuogoogle commented 1 year ago

/retest

google-oss-prow[bot] commented 1 year ago

@minzhuogoogle: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to [this](https://github.com/GoogleCloudPlatform/testgrid/pull/1259#issuecomment-1740182469): >/ok-to-test Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
google-oss-prow[bot] commented 1 year ago

@minzhuogoogle: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to [this](https://github.com/GoogleCloudPlatform/testgrid/pull/1259#issuecomment-1740182581): >/retest Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
michelle192837 commented 1 year ago

/ok-to-test

minzhuogoogle commented 1 year ago

/test test-testgrid-all

google-oss-prow[bot] commented 1 year ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: michelle192837, minzhuogoogle

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/GoogleCloudPlatform/testgrid/blob/master/OWNERS)~~ [michelle192837] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment