GoogleCloudPlatform / testgrid

Apache License 2.0
193 stars 68 forks source link

Add links for alerts, and utilities to process link templates. #1264

Closed michelle192837 closed 9 months ago

michelle192837 commented 9 months ago

The frontend currently processes links, but any components that want to use links (like Summarizer or downstream components) can't really do so. Replicate the logic for link-template parsing so we can make use of the user-specified links instead of hard-coded ones.

google-oss-prow[bot] commented 9 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: michelle192837, sultan-duisenbay

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/GoogleCloudPlatform/testgrid/blob/main/OWNERS)~~ [michelle192837,sultan-duisenbay] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
michelle192837 commented 9 months ago

qq - why are we checking and logging the new links instead of overwriting the existing ones in the failing test summaries? This part is unclear to me.

Otherwise, looks good to me functionality wise.

/hold

Good question, thanks! I don't want to break existing use of the links until I verify that everything's working as expected, especially since we haven't touched this in a while (and I suspect I'm missing some invisible assumption about how this works for some tabs). I expect to follow up with one or two more changes before enabling (probably including a flag to flip this behavior for the Summarizer).

michelle192837 commented 9 months ago

/hold cancel