Closed michelle192837 closed 9 months ago
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: michelle192837, sultan-duisenbay
The full list of commands accepted by this bot can be found here.
The pull request process is described here
qq - why are we checking and logging the new links instead of overwriting the existing ones in the failing test summaries? This part is unclear to me.
Otherwise, looks good to me functionality wise.
/hold
Good question, thanks! I don't want to break existing use of the links until I verify that everything's working as expected, especially since we haven't touched this in a while (and I suspect I'm missing some invisible assumption about how this works for some tabs). I expect to follow up with one or two more changes before enabling (probably including a flag to flip this behavior for the Summarizer).
/hold cancel
The frontend currently processes links, but any components that want to use links (like Summarizer or downstream components) can't really do so. Replicate the logic for link-template parsing so we can make use of the user-specified links instead of hard-coded ones.