search

GoogleCloudPlatform / testgrid

Apache License 2.0
193 stars 68 forks source link

Clarify message for missing podinfo.json. #1272

Closed michelle192837 closed 5 months ago

michelle192837 commented 5 months ago

TestGrid expects that podinfo.json is uploaded by the time that finished.json is, and will either report it as a running/pending status if finished.json isn't uploaded yet, or as a failure if it is.

The message that appears on the .Pod cell isn't clear about this case, so updating the message to include it. (The previous case mentioned, where Prow's GCS reporter isn't enabled, still applies, but podinfo.json can fail to be uploaded for other reasons as well).

listx commented 5 months ago

/lgtm /hold for others?

google-oss-prow[bot] commented 5 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: airbornepony, chases2, michelle192837

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/GoogleCloudPlatform/testgrid/blob/main/OWNERS)~~ [chases2,michelle192837] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
michelle192837 commented 5 months ago

/hold cancel

Updated description/commit as well. Thanks folks!