search

GoogleCloudPlatform / testgrid

Apache License 2.0
193 stars 68 forks source link

Use SearchConfiguredTargets when searching targets. #1280

Closed michelle192837 closed 5 months ago

michelle192837 commented 5 months ago

If searching for a target (as opposed to labels or other identifiers), we want to search for those results using a difference method (SearchConfiguredTargets, rather than SearchInvocations). Add the search method and use it if the query contains a target atom (and update the Prow label accordingly for this search).

Moved the query code into a separate package so it can be used in config validation without a circular dependency.

google-oss-prow[bot] commented 5 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: michelle192837

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/GoogleCloudPlatform/testgrid/blob/main/OWNERS)~~ [michelle192837] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
listx commented 5 months ago

Moved the query code into a separate package so it can be used in config validation without a circular dependency.

Nit: if you did this first in a separate commit, (NOP change) then that would have made it a touch easier to review the business logic changes.

listx commented 5 months ago

/lgtm /hold ?

michelle192837 commented 5 months ago

Noted for future, thanks! ^^

/hold cancel