GoogleCloudPlatform / testgrid

Apache License 2.0
198 stars 68 forks source link

Update job.go #1284

Open minzhuogoogle opened 6 months ago

minzhuogoogle commented 6 months ago

Add metadata in order to extract metadata in podinfo.json

google-oss-prow[bot] commented 6 months ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: minzhuogoogle Once this PR has been reviewed and has the lgtm label, please assign michelle192837 for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/GoogleCloudPlatform/testgrid/blob/main/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
google-oss-prow[bot] commented 6 months ago

Hi @minzhuogoogle. Thanks for your PR.

I'm waiting for a GoogleCloudPlatform member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
michelle192837 commented 6 months ago

Hi! Just checking, but what's the reason for this addition? (iiuc I think podinfo.json isn't always expected to be uploaded, but the relevant metadata should be present in finished.json if needed)