Open michelle192837 opened 3 weeks ago
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: michelle192837
The full list of commands accepted by this bot can be found here.
The pull request process is described here
@michelle192837: The following test failed, say /retest
to rerun all failed tests or /retest-required
to rerun all mandatory failed tests:
Test name | Commit | Details | Required | Rerun command |
---|---|---|---|---|
test-testgrid-all | 4d3af7f9a7f400f37e806dcb10288eb40f5cf01c | link | true | /test test-testgrid-all |
Found an issue with a growing number of goroutines that didn't pop up on a simple search but does with a more complex search. I need to fix that before this is good to roll out.
Instead of requiring
label:"prow"
in queries, allow any number of label or target atoms in a query. (This still limits the queries we accept, but it should work for most simple uses of ResultStore sources).Test: Unit tests, and verified with a local instance of TestGrid that a ResultStore source config will pick up results from ResultStore correctly.