GoogleCloudPlatform / testgrid

Apache License 2.0
198 stars 68 forks source link

WIP: Allow label/target search for ResultStore sources. #1296

Open michelle192837 opened 3 weeks ago

michelle192837 commented 3 weeks ago

Instead of requiring label:"prow" in queries, allow any number of label or target atoms in a query. (This still limits the queries we accept, but it should work for most simple uses of ResultStore sources).

Test: Unit tests, and verified with a local instance of TestGrid that a ResultStore source config will pick up results from ResultStore correctly.

google-oss-prow[bot] commented 3 weeks ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: michelle192837

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/GoogleCloudPlatform/testgrid/blob/main/OWNERS)~~ [michelle192837] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
google-oss-prow[bot] commented 3 weeks ago

@michelle192837: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
test-testgrid-all 4d3af7f9a7f400f37e806dcb10288eb40f5cf01c link true /test test-testgrid-all
Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
michelle192837 commented 3 weeks ago

Found an issue with a growing number of goroutines that didn't pop up on a simple search but does with a more complex search. I need to fix that before this is good to roll out.