GoogleCloudPlatform / traffic-director-grpc-bootstrap

Apache License 2.0
20 stars 18 forks source link

Changes to support xDS Federation #33

Closed arvindbr8 closed 2 years ago

arvindbr8 commented 2 years ago

as per a47 xDS Federation spec we need to add the authorities field. For the authorities field, we want two entries:

Note that in authorities map authority name's value is empty. This is to force default to the xds_server_uri specified in the top level xds_servers field.

Fixes task 1 in #32

easwars commented 2 years ago

@ejona86 : I have reviewed this PR and looks fine to me. Do you mind taking a quick look as well? Thanks.

easwars commented 2 years ago

The changes look fine, but this doesn't actually fix #32 entirely, correct, because we want the c2p stuff to be present?

Yes, this change only addresses basic federation. The c2p changes would follow after this.

arvindbr8 commented 2 years ago

Yes I can add c2p changes as a separate task in #32