Closed arvindbr8 closed 2 years ago
@ejona86 : I have reviewed this PR and looks fine to me. Do you mind taking a quick look as well? Thanks.
The changes look fine, but this doesn't actually fix #32 entirely, correct, because we want the c2p stuff to be present?
Yes, this change only addresses basic federation. The c2p changes would follow after this.
Yes I can add c2p changes as a separate task in #32
as per a47 xDS Federation spec we need to add the authorities field. For the authorities field, we want two entries:
Note that in
authorities
map authority name's value is empty. This is to force default to thexds_server_uri
specified in the top levelxds_servers
field.Fixes task 1 in #32