search

GoogleCloudPlatform / training-data-analyst

Labs and demos for courses for GCP Training (http://cloud.google.com/training).
Apache License 2.0
7.87k stars 5.86k forks source link

Nodejs upgrade is appengine demo #1155

Open tulsiksng opened 4 years ago

tulsiksng commented 4 years ago

https://github.com/GoogleCloudPlatform/training-data-analyst/blob/b7dd4b77c3f9f62860f6456407a48a455cb9d97b/courses/developingapps/v1.2/java/appengine/start/prepare_environment.sh#L41

Please update the nodejs to latest version

Current line: gcloud functions deploy process-feedback --runtime nodejs8 --trigger-topic feedback --source ./function --stage-bucket $GCLOUD_BUCKET --entry-point subscribe

Updated line: gcloud functions deploy process-feedback --runtime nodejs10 --trigger-topic feedback --source ./function --stage-bucket $GCLOUD_BUCKET --entry-point subscribe

While running demo application it is throwing warning saying: WARNING: The Node.js 8 runtime is deprecated on Cloud Functions. Please migrate to Node.js 10 (--runtime=nodejs10)

aalokmehta commented 10 months ago

Update 12/4/2023: NodeJS8 is no longer supported. This means that this example fails.

developingapps/...

nodejs/cloudfunctions/end/prepare_environment.sh

nodejs/appengine/start/prepare_environment.sh nodejs/appengine/end/prepare_environment.sh

nodejs/stackdriver-trace-monitoring/start/prepare_environment.sh

nodejs/cloudendpoints/start/prepare_environment.sh nodejs/cloudendpoints/end/prepare_environment.sh nodejs/cloudendpoints/bonus/prepare_environment.sh

nodejs/stackdriver-debug-errorreporting/start/prepare_incomplete_environment.sh nodejs/stackdriver-debug-errorreporting/end/prepare_incomplete_environment.sh

python/appengine/start/prepare_environment.sh python/appengine/end/prepare_environment.sh

java/appengine/start/prepare_environment.sh java/appengine/end/prepare_environment.sh

And others, by version number.