search

GoogleCloudPlatform / training-data-analyst

Labs and demos for courses for GCP Training (http://cloud.google.com/training).
Apache License 2.0
7.84k stars 5.85k forks source link

Identified issues with tfdv_basic_spending.ipynb #2642

Open ylnhari opened 2 months ago

ylnhari commented 2 months ago

training-data-analyst/courses/machine_learning/deepdive2/production_ml/solutions/tfdv_basic_spending.ipynb might be having mistakes

  1. without disclosing data location , asked user to write code to read data (train and test) in the first few cells of the notebook
  2. unnecessary comment confusing user's (could be from tfdv taxi example but relevant here ) . Here are those comments:-
    • Notice that there are no examples with values for pickup_census_tract. This is an opportunity for dimensionality reduction!
    • Try switching between the log and linear scales, and notice how the log scale reveals much more detail about the payment_type categorical feature
google-cla[bot] commented 2 months ago

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

review-notebook-app[bot] commented 2 months ago

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB