search

GoogleCloudPlatform / training-data-analyst

Labs and demos for courses for GCP Training (http://cloud.google.com/training).
Apache License 2.0
7.87k stars 5.86k forks source link

Small Typo on Sklearn + Cloud ML Tutorial #280

Closed euhuang closed 6 years ago

euhuang commented 6 years ago

On the Jupyter Notebook (https://github.com/GoogleCloudPlatform/training-data-analyst/blob/master/blogs/sklearn/babyweight_skl.ipynb), there's a small typo. In the 3rd coding cell under the section "Packaging up as a Python package", and for the "install_requires" argument, it says 'cloudml-hypertune,'. The comma should go outside of the string and not within the string. The file generated by the %writefile magic function (babyweight/setup.py) of that coding cell is actually correct, so my guess is that the Jupyter Notebook cell must have been changed after the the file was written.

Thanks Lak for the great tutorials! On my team, we definitely following them carefully and closely.

alexhanna commented 6 years ago

Thanks for pointing this out! Fixed.

euhuang commented 6 years ago

We need a Staples button: That was easy!

Thanks!