search

GoogleCloudPlatform / vertex-ai-samples

Notebooks, code samples, sample apps, and other resources that demonstrate how to use, develop and manage machine learning and generative AI workflows using Google Cloud Vertex AI.
https://cloud.google.com/vertex-ai
Apache License 2.0
115 stars 27 forks source link

refactor: NVIDIA NIM verbiage updates, minor code updates #3655

Closed sujituk closed 1 month ago

sujituk commented 1 month ago

REQUIRED: Add a summary of your PR here, typically including why the change is needed and what was changed. Include any design alternatives for discussion purposes.


Updates to colab notebook descriptions and rename of notebook


REQUIRED: Fill out the below checklists or remove if irrelevant

  1. If you are opening a PR for Official Notebooks under the notebooks/official folder, follow this mandatory checklist:
    • [x] Use the notebook template as a starting point.
    • [x] Follow the style and grammar rules outlined in the above notebook template.
    • [x] Verify the notebook runs successfully in Colab since the automated tests cannot guarantee this even when it passes.
    • [x] Passes all the required automated checks. You can locally test for formatting and linting with these instructions.
    • [x] You have consulted with a tech writer to see if tech writer review is necessary. If so, the notebook has been reviewed by a tech writer, and they have approved it.
    • [x] This notebook has been added to the CODEOWNERS file under the Official Notebooks section, pointing to the author or the author's team.
    • [x] The Jupyter notebook cleans up any artifacts it has created (datasets, ML models, endpoints, etc) so as not to eat up unnecessary resources.


  1. If you are opening a PR for Community Notebooks under the notebooks/community folder:
    • [ ] This notebook has been added to the CODEOWNERS file under the Community Notebooks section, pointing to the author or the author's team.
    • [ ] Passes all the required formatting and linting checks. You can locally test with these instructions.


  1. If you are opening a PR for Community Content under the community-content folder:
    • [ ] Make sure your main Content Directory Name is descriptive, informative, and includes some of the key products and attributes of your content, so that it is differentiable from other content
    • [ ] The main content directory has been added to the CODEOWNERS file under the Community Content section, pointing to the author or the author's team.
    • [ ] Passes all the required formatting and linting checks. You can locally test with these instructions.
review-notebook-app[bot] commented 1 month ago

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB