GoogleCloudPlatform / vertex-pipelines-end-to-end-samples

Apache License 2.0
225 stars 89 forks source link

Separate python deps #27

Closed ghost closed 1 year ago

ghost commented 1 year ago

Description

The aim of this PR is to separate the Python dependencies for each pipeline component from each other component and from the ML pipelines themselves. There are a lot of files changed (!) but this mostly consists of files moving and some import statements being updated. The key changes are:

How has this been tested?

Checklist

simonbutt-datatonic commented 1 year ago

Add:

pipeline_components/evaluation/example_count.py 
pipeline_components/evaluation/plots_num_feat.html
pipeline_components/evaluation/plots_overall.html

to .gitignore or clean during specific test. These files are created when running make test-all-components

simonbutt-datatonic commented 1 year ago

pipeline_components/_tfdv/_tfdv/conftest.py if empty, is it needed?

ghost commented 1 year ago

Add:

pipeline_components/evaluation/example_count.py 
pipeline_components/evaluation/plots_num_feat.html
pipeline_components/evaluation/plots_overall.html

to .gitignore or clean during specific test. These files are created when running make test-all-components

Added to .gitignore for this PR. Created #29 to track it and will address properly in a future PR

ghost commented 1 year ago

pipeline_components/_tfdv/_tfdv/conftest.py if empty, is it needed?

Yes this is required for pytest to pick up the directory so that the contents can be imported during tests

simonbutt-datatonic commented 1 year ago

In that case potentially add a comment stating the purpose in the file. Otherwise can image people developing on the template could remove without realising the failing test consequence

ghost commented 1 year ago

In that case potentially add a comment stating the purpose in the file. Otherwise can image people developing on the template could remove without realising the failing test consequence

Added

ghost commented 1 year ago

@Linchin ready for your review :)