search

GoogleCloudPlatform / webapp2

webapp2 is a framework for Google App Engine
https://webapp2.readthedocs.org
Other
142 stars 64 forks source link

Make webapp2_extras/appengine/auth/models.User.validate_token return … #109

Closed karlwmacmillan closed 8 years ago

karlwmacmillan commented 8 years ago

…UserToken or None.

Make the implementation of webapp2_extras/appengine/auth/models.User.validate_token match the documentation and return the UserToken instead of Bool. Also correct the unit tests.

This fixes issue #102.

googlebot commented 8 years ago

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

:memo: Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.

codecov-io commented 8 years ago

Current coverage is 95.80%

Merging #109 into master will not affect coverage as of 442b167

@@            master   #109   diff @@
=====================================
  Files           23     23       
  Stmts         1884   1884       
  Branches       286    286       
  Methods          0      0       
=====================================
  Hit           1805   1805       
  Partial         58     58       
  Missed          21     21

Review entire Coverage Diff as of 442b167

Powered by Codecov. Updated on successful CI builds.

karlwmacmillan commented 8 years ago

I signed it!

googlebot commented 8 years ago

CLAs look good, thanks!

theacodes commented 8 years ago

Thanks, @karlwmacmillan!