search

GoogleCloudPlatform / webapp2

webapp2 is a framework for Google App Engine
https://webapp2.readthedocs.org
Other
141 stars 63 forks source link

Send request headers (cookies) with abort=True requests too. #112

Closed mikelambert closed 8 years ago

mikelambert commented 8 years ago

This should fix https://github.com/GoogleCloudPlatform/webapp2/issues/111

codecov-io commented 8 years ago

Current coverage is 95.57%

Merging #112 into master will increase coverage by <.01%

  1. File webapp2.py was modified. more
@@             master       #112   diff @@
==========================================
  Files            23         23          
  Lines          1893       1895     +2   
  Methods           0          0          
  Messages          0          0          
  Branches        286        287     +1   
==========================================
+ Hits           1809       1811     +2   
  Misses           26         26          
  Partials         58         58

Powered by Codecov. Last updated by 6d6ea5b...46430cb

theacodes commented 8 years ago

Can please update/add appropriate tests?

mikelambert commented 8 years ago

Updated my pull request to include a simple test. I can't test nosetests locally since it depends on GAE paths in some way I don't feel like debugging. (Ideally the README would explain how to run tests?) But pushing the change up here, it seems to pass on travis.

theacodes commented 8 years ago

Cool, LGTM.