search

GoogleCloudPlatform / webapp2

webapp2 is a framework for Google App Engine
https://webapp2.readthedocs.org
Other
141 stars 63 forks source link

Typo in app.yaml's handlers script invocation. #125

Closed toanant closed 7 years ago

toanant commented 7 years ago

Travis CI build failing due to flake8 --import-order-style=google webapp2.py webapp2_extras tests example failed not related to this particular change.

googlebot commented 7 years ago

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for the commit author(s). If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.

codecov-io commented 7 years ago

Codecov Report

Merging #125 into master will not change coverage. The diff coverage is 100%.

@@           Coverage Diff           @@
##           master     #125   +/-   ##
=======================================
  Coverage   95.81%   95.81%           
=======================================
  Files          18       18           
  Lines        1817     1817           
  Branches      274      274           
=======================================
  Hits         1741     1741           
  Misses         19       19           
  Partials       57       57
Impacted Files Coverage Δ
webapp2_extras/xsrf.py 93.44% <ø> (ø) :white_check_mark:
webapp2_extras/auth.py 96.85% <100%> (ø) :white_check_mark:
webapp2_extras/json.py 100% <100%> (ø) :white_check_mark:
webapp2.py 95.47% <100%> (ø) :white_check_mark:
webapp2_extras/sessions.py 96.37% <100%> (ø) :white_check_mark:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 81dde22...42384ef. Read the comment docs.

googlebot commented 7 years ago

CLAs look good, thanks!

toanant commented 7 years ago

Fixed lint errors.

toanant commented 7 years ago

It'll close issue #98 and #93