Open remko opened 4 years ago
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).
:memo: Please visit https://cla.developers.google.com/ to sign.
Once you've signed (or fixed any issues), please reply here with @googlebot I signed it!
and we'll verify it.
ℹ️ Googlers: Go here for more info.
Merging #150 into master will decrease coverage by
0.99%
. The diff coverage is100%
.
@@ Coverage Diff @@
## master #150 +/- ##
========================================
- Coverage 95.81% 94.82% -1%
========================================
Files 17 16 -1
Lines 1818 1604 -214
Branches 274 252 -22
========================================
- Hits 1742 1521 -221
- Misses 19 33 +14
+ Partials 57 50 -7
Impacted Files | Coverage Δ | |
---|---|---|
webapp2_extras/auth.py | 96.85% <ø> (ø) |
:arrow_up: |
webapp2_extras/sessions.py | 96.37% <ø> (ø) |
:arrow_up: |
webapp2_extras/appengine/sessions_memcache.py | 94.11% <ø> (ø) |
:arrow_up: |
webapp2.py | 92.86% <ø> (-2.63%) |
:arrow_down: |
webapp2_extras/routes.py | 92.06% <ø> (ø) |
:arrow_up: |
webapp2_extras/appengine/sessions_ndb.py | 94.59% <100%> (ø) |
:arrow_up: |
tests/resources/i18n.py |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update deb3444...3bf01f6. Read the comment docs.
Fixes #139 and #140
Mostly fixing this so someone can approve the other critical PRs ( such as #147 )