search

GoogleCloudPlatform / webapp2

webapp2 is a framework for Google App Engine
https://webapp2.readthedocs.org
Other
141 stars 63 forks source link

tests in config_test.py modify, but do not restore API stubs (with ext.testbed) #71

Open GoogleCodeExporter opened 8 years ago

GoogleCodeExporter commented 8 years ago 
All test classes in 
http://code.google.com/p/webapp-improved/source/browse/tests/extras_config_test.
py override the tearDown() method to be a NOP. 

The base class uses testbed to modify the API stubs in setUp(), and restores 
the state from before the test run in tearDown(). This restoration is missing 
and therefore subsequent tests, when run in an App Engine environment will fail.

This NOP override was introduced in revision 
e695037ee41d48a6a7de42cb19c60fc8c26ced3c 
(http://code.google.com/p/webapp-improved/source/detail?spec=svne695037ee41d48a6
a7de42cb19c60fc8c26ced3c&r=e695037ee41d48a6a7de42cb19c60fc8c26ced3c), but I 
don't understand why it was done. 
Would it be possible to remove the override?

Original issue reported on code.google.com by schu...@google.com on 31 Oct 2012 at 8:05