search

GoogleCloudPlatform / wsi-to-dicom-converter

Conversion tool/library for converting whole slide images to DICOM
Apache License 2.0
77 stars 26 forks source link

Fix minor mistakes that was found by PVS-Studio #108

Closed SibgatullinAP closed 1 year ago

SibgatullinAP commented 1 year ago

This PR contains fixes for some mistakes that was found by PVS Studio (static code analyzer https://pvs-studio.com/en/). Although there was more mistakes that was found by PVS, i've decided to fix only obvious ones. If you are interested in other mistakes i can send you a full report from PVS.

google-cla[bot] commented 1 year ago

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

Philbrick commented 1 year ago

/gcbrun

Philbrick commented 1 year ago

Thank-you for your contribution. Please complete the Contributor License Agreement (CLA). After you do this, we should able to merge your changes. Yes, if possible please share the additional PVS findings in a comment.

SibgatullinAP commented 1 year ago

Hi! Sources for HTML report can be found here https://github.com/SibgatullinAP/sc_computational_models/tree/main/hw_1/1_5b/PVS_report. Just copy folder and open index.html in your browser. If you want just to take a look at the PVS-report you can open pdf below: jbubc-67hd1.pdf

Philbrick commented 1 year ago

/gcbrun