search

GoogleCloudPlatform / wsi-to-dicom-converter

Conversion tool/library for converting whole slide images to DICOM
Apache License 2.0
77 stars 26 forks source link

Fix build on current ubuntu #58

Closed jcupitt closed 3 years ago

jcupitt commented 3 years ago

A couple of small changes are needed to build on Ubuntu 21.04.

danielbeaudreau commented 3 years ago

/gcbrun

danielbeaudreau commented 3 years ago

Thanks. This is currently failing the lint check: docker.io/library/python:2.7 ././src/dcmTags.cpp:28: Line ends in whitespace. Consider deleting these extra spaces. [whitespace/end_of_line] [4]

jcupitt commented 3 years ago

Oh, curious, that's not a line I touched. I've removed the space anyway. Thanks for reviewing.

danielbeaudreau commented 3 years ago

/gcbrun

danielbeaudreau commented 3 years ago

Unfortunately this does not seem to build on presubmits:

/workspace/src/dcmTags.cpp: In function 'Json::Value readJsonTag(Json::Value, std::string)': /workspace/src/dcmTags.cpp:33:22: error: could not convert '(& obj.Json::Value::operator)->Json::Value::operator[](((const char*)(& VALUE)))' from 'Json::Value' to 'bool' 33 if (obj[tag][VALUE]) { ^
Json::Value

[ 96%] Building CXX object CMakeFiles/wsi2dcm.dir/src/wsiToDcm.cpp.o

danielbeaudreau commented 3 years ago

Closing as obsolete. Feel free to re-open if anything changes.