search

GoogleCloudPlatform / wsi-to-dicom-converter

Conversion tool/library for converting whole slide images to DICOM
Apache License 2.0
76 stars 26 forks source link

Refactor for Pruning update #70

Closed Philbrick closed 3 years ago

Philbrick commented 3 years ago

Move variables into WsiToDcm to simplify/clean class methods. Add basic max/min for int command line parameters. Remove cWrapper.h cWrapper.cpp

danielbeaudreau commented 3 years ago

/gcbrun

danielbeaudreau commented 3 years ago

/gcbrun

danielbeaudreau commented 3 years ago

Looks good, just wondering why we need the c wrapper still?

Philbrick commented 3 years ago

I'm not sure we do need the C interface. I removed it, then had second thoughts, that it must have been created for a reason, maybe interfacing e.g., JNI? I thought if I could easily bring it forward I should.