search

GoogleCloudPlatform / zetasql-toolkit

The ZetaSQL Toolkit is a library that helps users use ZetaSQL Java API to perform SQL analysis for multiple query engines, including BigQuery and Cloud Spanner.
Apache License 2.0
39 stars 10 forks source link

zetasql-toolkit depends on concrete slf4j-simple #24

Closed hamnis closed 6 months ago

hamnis commented 1 year ago

It should either be in test-scope or optional.

for now an exclusion is needed if you use any other slf4j backend.

ppaglilla commented 1 year ago

Thanks for calling this out!

I removed both the slf4j-api and slf4j-simple dependencies from zetasql-toolkit-core, neither were required. The next release (0.5.0) will not include them and should be released in just a few days.

zetasql-toolkit-bigquery will still depend on slf4j-api:1.7.25, since that is a transitive dependency of the BigQuery client library.

hamnis commented 8 months ago

@ppaglilla any chance of getting a release which fixes this out ?

ppaglilla commented 6 months ago

Apologies for the delayed responses here! I'm releasing a new version with this fix in the next few days, likely as soon as we merge https://github.com/GoogleCloudPlatform/zetasql-toolkit/pull/33.