Valid dataset id is flagged as invalid due to incorrect regex pattern

GoogleCloudPlatform / zetasql-toolkit

The ZetaSQL Toolkit is a library that helps users use ZetaSQL Java API to perform SQL analysis for multiple query engines, including BigQuery and Cloud Spanner.

Apache License 2.0

39 stars 10 forks source link

Valid dataset id is flagged as invalid due to incorrect regex pattern #68

Closed dion-ricky closed 4 months ago

dion-ricky commented 4 months ago

During parsing I got an invalid BigQuery reference error, after looking at the code I realized that this regex pattern is the reason: https://github.com/GoogleCloudPlatform/zetasql-toolkit/blob/d31b44cb0f45f73f20c52deaba87cae79e399fdf/zetasql-toolkit-bigquery/src/main/java/com/google/zetasql/toolkit/catalog/bigquery/BigQueryReference.java#L33

BigQuery dataset name can contain any letters, numbers, and underscores, https://cloud.google.com/bigquery/docs/datasets#dataset-naming.

ppaglilla commented 4 months ago

Reviewing the PR!

dion-ricky commented 4 months ago

I have opened new PR #72. Please check, thanks

ppaglilla commented 4 months ago

Merged for version 0.5.3