GoogleCodeArchive / msnp-sharp

Automatically exported from code.google.com/p/msnp-sharp
0 stars 0 forks source link

MsnpSharp does not handle "company" phone type #255

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
Thanks to WP7, Live contacts can now contain a "Company" phone number (I'm not 
really sure how this is supposed to differ from Work1 or Work2)

When MSNPSharp runs into a contact with "Company" phone number set, it throws 
{"Instance validation error: 'Company' is not a valid value for 
ContactPhoneTypeType."}

By adding just "Company" to ContactPhoneTypeType (in Reference.cs), parsing is 
fixed. I couldn't see a way to submit patches or a mailing list, so this seemed 
like the best way to submit a bug/fix in one.

Additionally, since there are now 10 phone number types, but only 3 exposed in 
MsnpContact, perhaps it would be best to have a List or Dictionary of phone 
numbers, instead of getter/setters for 3?

ie: on Contact have Dictionary<ContactPhoneTypeType, String> PhoneNumbers {get; 
set;} to replace HomePhone, WorkPhone, MobilePhone?

Original issue reported on code.google.com by theleagu...@gmail.com on 8 Feb 2011 at 11:09

GoogleCodeExporter commented 9 years ago
This issue was updated by revision r2009.

Original comment by hepha...@gmail.com on 9 Feb 2011 at 9:11