GoogleCodeArchive / musicpm

Automatically exported from code.google.com/p/musicpm
0 stars 1 forks source link

Firefox 18.0 crashes at startup with Music Player Minion enabled #127

Open GoogleCodeExporter opened 9 years ago

GoogleCodeExporter commented 9 years ago
What steps will reproduce the problem?
1. Install or update to Firefox 18
2. If you have MPM enabled, FF will crash at startup
3. Even if you reinstall MPM, it will still crash

What is the expected output? What do you see instead?
I expected to continue using MPM, but had to disable it because FF 18 won't 
start with it.

What version are you using? On what operating system?
Music Player Minion: 2.2 (and also tried with the patched 2.1.3 from 
http://www.gargan.org/en/Mozilla_Extensions/Music_Player_Minion/ )
Firefox: 18.0
Music player Daemon (MPD): 0.16.6
OS: Windows 7

Please provide any additional information below.

Here is a list of changes to FF 18 that could have an impact on MPM:
https://developer.mozilla.org/en-US/docs/Firefox_18_for_developers

Also, while restarting firefox with MPM enabled, it seems that everything is 
fine for about 1 second but then firefox crashes. I had to disable the add-on 
to continue using FF.

Original issue reported on code.google.com by samon...@gmail.com on 8 Jan 2013 at 7:21

GoogleCodeExporter commented 9 years ago
More information:

The crash only appears to happen when MPM tries to successfully connect to a 
MPD server. All the windows, preferences, etc, seem to work fine when the MPD 
server is not available.

When trying to connect to a MPD server, it crashes with these two errors:

Error: this.docShell is null
Source File: chrome://global/content/bindings/browser.xml
Line: 323

Error: TypeError: aUrl is undefined
Source File: chrome://browser/content/urlbarBindings.xml
Line: 642

Original comment by samon...@gmail.com on 9 Jan 2013 at 10:31

GoogleCodeExporter commented 9 years ago
I have the same issue on Firefox 18 and Windows 8. On Firefox 18 and Debian it 
is OK.
On W8 it starts to crash when browsing files. 

Original comment by vasiliev...@gmail.com on 7 Feb 2013 at 9:30

GoogleCodeExporter commented 9 years ago
I don't know what's musicpm (sorry), but know one of your bugs.

With clean firefox installation, without opening any new tab,
after leaving urlbar i got this error message in error console:

("Error: TypeError: aUrl is undefined
Source file: chrome://browser/content/urlbarBindings.xml
Line: 642
")

It's still in firefox 21.0a1, remember it since few relases ago,
now just confirming it.

Firefox source file: chrome://browser/content/urlbarBindings.xml:

      <method name="_parseActionUrl">
        <parameter name="aUrl"/>
        <body><![CDATA[
          if (!aUrl.startsWith("moz-action:"))
            return null;

          // url is in the format moz-action:ACTION,PARAM
          let [, action, param] = aUrl.match(/^moz-action:([^,]+),(.*)$/);
          return {type: action, param: param};
        ]]></body>
      </method>

probably shall be:

      <method name="_parseActionUrl">
        <parameter name="aUrl"/>
        <body><![CDATA[
          if (!aUrl || !aUrl.startsWith("moz-action:"))
            return null;

          // url is in the format moz-action:ACTION,PARAM
          let [, action, param] = aUrl.match(/^moz-action:([^,]+),(.*)$/);
          return {type: action, param: param};
        ]]></body>
      </method>

https://bugzilla.mozilla.org/ is right place to solve it,
providing accurate information - what probably I may do
one day..

Original comment by vir...@inbox.com on 13 Feb 2013 at 1:42

GoogleCodeExporter commented 9 years ago
There is actually bug for that:

Bug 829197 - Various weird warnings on startup 

https://bugzilla.mozilla.org/show_bug.cgi?id=829197

Original comment by vir...@inbox.com on 13 Feb 2013 at 2:05

GoogleCodeExporter commented 9 years ago
It seems that it was a Firefox bug after all since MPM started working again 
with FF 19.0.2

Original comment by samon...@gmail.com on 20 Mar 2013 at 5:43