search

GoogleCodeArchive / piccolo2d

Automatically exported from code.google.com/p/piccolo2d
0 stars 0 forks source link

New round of clirr errors, as of r624 #116

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
$ clirr.sh -n core/target/piccolo2d-core-1.3-SNAPSHOT.jar -o
piccolo2d-core-1.2.1.jar
INFO: 7007: edu.umd.cs.piccolo.PCamera: Method 'public void
repaintFromLayer(edu.umd.cs.piccolo.util.PBounds,
edu.umd.cs.piccolo.PNode)' has
 been deprecated
INFO: 7011: edu.umd.cs.piccolo.PCamera: Method 'public void
repaintFromLayer(edu.umd.cs.piccolo.util.PBounds,
edu.umd.cs.piccolo.PLayer)' ha
s been added
INFO: 6000: edu.umd.cs.piccolo.PCanvas: Added public field
INTERACTING_CHANGED_NOTIFICATION
INFO: 7011: edu.umd.cs.piccolo.PCanvas: Method 'public int
getAnimatingRenderQuality()' has been added
INFO: 7011: edu.umd.cs.piccolo.PCanvas: Method 'public int
getDefaultRenderQuality()' has been added
INFO: 7011: edu.umd.cs.piccolo.PCanvas: Method 'public
edu.umd.cs.piccolo.event.PInputEventListener[] getInputEventListeners()'
has been add
ed
INFO: 7011: edu.umd.cs.piccolo.PCanvas: Method 'public int
getInteractingRenderQuality()' has been added
INFO: 7011: edu.umd.cs.piccolo.PNode: Method 'public
PNode(java.lang.String)' has been added
INFO: 7011: edu.umd.cs.piccolo.PNode: Method 'public
edu.umd.cs.piccolo.activities.PActivity
animateToRelativePosition(java.awt.geom.Point2D
, java.awt.geom.Point2D, java.awt.geom.Rectangle2D, int)' has been added
INFO: 7011: edu.umd.cs.piccolo.PNode: Method 'public
edu.umd.cs.piccolo.event.PInputEventListener[] getInputEventListeners()'
has been added

INFO: 7011: edu.umd.cs.piccolo.PNode: Method 'public java.lang.String
getName()' has been added
INFO: 7007: edu.umd.cs.piccolo.PNode: Method 'protected java.lang.String
paramString()' has been deprecated
INFO: 7007: edu.umd.cs.piccolo.PNode: Method 'public void
position(java.awt.geom.Point2D, java.awt.geom.Point2D,
java.awt.geom.Rectangle2D,
int)' has been deprecated
INFO: 7011: edu.umd.cs.piccolo.PNode: Method 'public void
setName(java.lang.String)' has been added
INFO: 7003: edu.umd.cs.piccolo.PNode: Method 'public java.lang.String
toString()' has been removed, but an inherited definition exists.
INFO: 6000: edu.umd.cs.piccolo.PRoot: Added public field
PROPERTY_CODE_INTERACTING_CHANGED
INFO: 6000: edu.umd.cs.piccolo.PRoot: Added public field
PROPERTY_INTERACTING_CHANGED
INFO: 7011: edu.umd.cs.piccolo.PRoot: Method 'public boolean
getInteracting()' has been added
INFO: 7011: edu.umd.cs.piccolo.PRoot: Method 'public void
setInteracting(boolean)' has been added
INFO: 7007: edu.umd.cs.piccolo.activities.PActivity: Method 'protected
java.lang.String paramString()' has been deprecated
INFO: 7003: edu.umd.cs.piccolo.activities.PActivity: Method 'public
java.lang.String toString()' has been removed, but an inherited definiti
on exists.
INFO: 7003: edu.umd.cs.piccolo.activities.PColorActivity: Method 'protected
java.lang.String paramString()' has been removed, but an inherit
ed definition exists.
INFO: 7003: edu.umd.cs.piccolo.activities.PInterpolatingActivity: Method
'protected java.lang.String paramString()' has been removed, but an
 inherited definition exists.
INFO: 7003: edu.umd.cs.piccolo.activities.PTransformActivity: Method
'protected java.lang.String paramString()' has been removed, but an inh
erited definition exists.
INFO: 7007: edu.umd.cs.piccolo.event.PBasicInputEventHandler: Method
'protected java.lang.String paramString()' has been deprecated
INFO: 7003: edu.umd.cs.piccolo.event.PBasicInputEventHandler: Method
'public java.lang.String toString()' has been removed, but an inherited
 definition exists.
INFO: 7003: edu.umd.cs.piccolo.event.PDragEventHandler: Method 'protected
java.lang.String paramString()' has been removed, but an inherited
 definition exists.
INFO: 7003: edu.umd.cs.piccolo.event.PDragSequenceEventHandler: Method
'protected java.lang.String paramString()' has been removed, but an i
nherited definition exists.
ERROR: 6006: edu.umd.cs.piccolo.event.PInputEventFilter: Field
ALL_MODIFIERS_MASK is now final
INFO: 7011: edu.umd.cs.piccolo.event.PPanEventHandler: Method 'public
double getMaxAutoPanSpeed()' has been added
INFO: 7011: edu.umd.cs.piccolo.event.PPanEventHandler: Method 'public
double getMinAutoPanSpeed()' has been added
INFO: 7003: edu.umd.cs.piccolo.event.PPanEventHandler: Method 'protected
java.lang.String paramString()' has been removed, but an inherited
definition exists.
INFO: 7003: edu.umd.cs.piccolo.event.PZoomEventHandler: Method 'protected
java.lang.String paramString()' has been removed, but an inherited
 definition exists.
INFO: 7003: edu.umd.cs.piccolo.nodes.PImage: Method 'protected
java.lang.String paramString()' has been removed, but an inherited definition
 exists.
INFO: 7003: edu.umd.cs.piccolo.nodes.PPath: Method 'protected
java.lang.String paramString()' has been removed, but an inherited definition
exists.
INFO: 6000: edu.umd.cs.piccolo.nodes.PText: Added public field
DEFAULT_HORIZONTAL_ALIGNMENT
INFO: 6000: edu.umd.cs.piccolo.nodes.PText: Added public field DEFAULT_TEXT
INFO: 6000: edu.umd.cs.piccolo.nodes.PText: Added public field
DEFAULT_TEXT_PAINT
INFO: 6000: edu.umd.cs.piccolo.nodes.PText: Added public field
PROPERTY_CODE_TEXT_PAINT
INFO: 6000: edu.umd.cs.piccolo.nodes.PText: Added public field
PROPERTY_TEXT_PAINT
INFO: 7011: edu.umd.cs.piccolo.nodes.PText: Method 'public float
getHorizontalAlignment()' has been added
INFO: 7007: edu.umd.cs.piccolo.nodes.PText: Method 'public float
getJustification()' has been deprecated
INFO: 7011: edu.umd.cs.piccolo.nodes.PText: Method 'protected void
paintGreek(edu.umd.cs.piccolo.util.PPaintContext)' has been added
INFO: 7011: edu.umd.cs.piccolo.nodes.PText: Method 'protected void
paintText(edu.umd.cs.piccolo.util.PPaintContext)' has been added
INFO: 7003: edu.umd.cs.piccolo.nodes.PText: Method 'protected
java.lang.String paramString()' has been removed, but an inherited definition
exists.
INFO: 7011: edu.umd.cs.piccolo.nodes.PText: Method 'public void
setHorizontalAlignment(float)' has been added
INFO: 7007: edu.umd.cs.piccolo.nodes.PText: Method 'public void
setJustification(float)' has been deprecated
INFO: 7011: edu.umd.cs.piccolo.util.PAffineTransform: Method 'public
java.awt.geom.Point2D inverseTransform(java.awt.geom.Point2D, java.awt.
geom.Point2D)' has been added
INFO: 8000: edu.umd.cs.piccolo.util.PAffineTransformException: Class
edu.umd.cs.piccolo.util.PAffineTransformException added
ERROR: 6006: edu.umd.cs.piccolo.util.PUtil: Field NULL_ENUMERATION is now final
ERROR: 6006: edu.umd.cs.piccolo.util.PUtil: Field NULL_ITERATOR is now final
ERROR: 6006: edu.umd.cs.piccolo.util.PUtil: Field NULL_OUTPUT_STREAM is now
final

The ones that need addressing are:

INFO: 7003: edu.umd.cs.piccolo.PNode: Method 'public java.lang.String
toString()' has been removed, but an inherited definition exists.
INFO: 7003: edu.umd.cs.piccolo.activities.PInterpolatingActivity: Method
'protected java.lang.String paramString()' has been removed, but an
 inherited definition exists.
etc.

Some toString() and paramString() methods must remain in the codebase.

ERROR: 6006: edu.umd.cs.piccolo.event.PInputEventFilter: Field
ALL_MODIFIERS_MASK is now final
ERROR: 6006: edu.umd.cs.piccolo.util.PUtil: Field NULL_ENUMERATION is now final
ERROR: 6006: edu.umd.cs.piccolo.util.PUtil: Field NULL_ITERATOR is now final
ERROR: 6006: edu.umd.cs.piccolo.util.PUtil: Field NULL_OUTPUT_STREAM is now
final

For all of these, the final needs to be removed and a javadoc comment "Will
be made final in version 2.0." added

Original issue reported on code.google.com by heue...@gmail.com on 30 Jul 2009 at 3:29

GoogleCodeExporter commented 9 years ago 
I see. I cannot dowload clirr as the cvs gives me a connection refused and the 
maven
repo is maven 1 only. Can you redistribute clirr, so I can check myself as when 
I'm done?

I 'll address the last 4 within a few hours - the toString/paramString is INFO 
only,
do they have to be addressed?

Original comment by mr0...@mro.name on 30 Jul 2009 at 8:22

GoogleCodeExporter commented 9 years ago 
As of final see commits r625 + r626.

Original comment by mr0...@mro.name on 30 Jul 2009 at 9:15

GoogleCodeExporter commented 9 years ago 
The code cleaner is smarter than we are.  I like it.  ;)

No clirr errors or significant warnings remain.

I misunderstood the "...has been removed, but an inherited definition exists"
warnings before.  I took that to mean that a some subclass of PNode was still
overriding toString or paramString.  The warning actually says that in a 
subclass of
PNode, say PText, its paramString method was removed and it now defaults to the
deprecated definition in PNode, which is fine.

Original comment by heue...@gmail.com on 30 Jul 2009 at 5:14

GoogleCodeExporter commented 9 years ago 
Well, what shall I say. Every now and then I have my troubles deciphering the 
english
language subtleties. Especially when spoken from a machine.

So we're done?

P.S.: I was the cleaner.

Original comment by mr0...@mro.name on 30 Jul 2009 at 5:25

GoogleCodeExporter commented 9 years ago

Original comment by heue...@gmail.com on 30 Jul 2009 at 5:54