Refactor SWT examples from examples module to new swt-examples module

GoogleCodeExporter commented 9 years ago

Currently the examples maven module has dependencies on core, extras, and
swt.  The SWT examples should be refactored to a new swt-examples module so
that examples has dependencies on core and extras and swt-examples has
dependencies on core and swt.

Original issue reported on code.google.com by heue...@gmail.com on 12 Oct 2009 at 12:31

GoogleCodeExporter commented 9 years ago

Original comment by heue...@gmail.com on 12 Oct 2009 at 12:32

Changed state: Accepted
Added labels: Milestone-1.3

GoogleCodeExporter commented 9 years ago

Though, I'm not disagreeing, can you make the reasons for the change clear?

Original comment by allain.lalonde on 12 Oct 2009 at 6:05

GoogleCodeExporter commented 9 years ago

Say someone wants to run some examples for core Piccolo2D features.  They are
comfortable with Piccolo2D's software license, but object to SWT's software 
license.
 The examples module unnecessarily includes the swt module as a dependency.

One could push the argument further and suggest separate core-examples and
extras-examples modules.  Since core and extras have the same software license 
and
have no external dependencies, I don't see that as necessary.

Another possible benefit is a SWT-based ExampleRunner main class for the 
swt-examples
module.  Currently there is no access to SWT examples from the swing-based
ExampleRunner in the examples module.

Original comment by heue...@gmail.com on 12 Oct 2009 at 6:20

GoogleCodeExporter commented 9 years ago

Great. Agreed completely then. Your suggestion about breaking the core examples 
out
might not be too bad. Even doing so within the same module might be enough.

Original comment by allain.lalonde on 12 Oct 2009 at 6:27

GoogleCodeExporter commented 9 years ago

Refactoring in svn:

$ svn commit -m "Issue 132 ; refactoring SWT examples from examples module to 
new
swt-examples module, commit 1 of several" pom.xml swt-examples 
Sending        pom.xml
Adding         swt-examples
Adding         swt-examples/pom.xml
Adding         swt-examples/src
Adding         swt-examples/src/main
Adding         swt-examples/src/main/java
Adding         swt-examples/src/main/java/edu
Adding         swt-examples/src/main/java/edu/umd
Adding         swt-examples/src/main/java/edu/umd/cs
Adding         swt-examples/src/main/java/edu/umd/cs/piccolox
Adding         swt-examples/src/main/java/edu/umd/cs/piccolox/swt
Adding         swt-examples/src/main/java/edu/umd/cs/piccolox/swt/examples
Adding         
swt-examples/src/main/java/edu/umd/cs/piccolox/swt/examples/Temp.java
Adding        
swt-examples/src/main/java/edu/umd/cs/piccolox/swt/examples/package-info.java
Transmitting file data ....
Committed revision 712.

$ svn mv -m "Issue 132 ; refactoring SWT examples from examples module to new
swt-examples module, commit 2 of several"
https://piccolo2d.googlecode.com/svn/piccolo2d.java/trunk/examples/src/main/java
/edu/umd/cs/piccolo/examples/swt/SWTHelloWorld.java
https://piccolo2d.googlecode.com/svn/piccolo2d.java/trunk/swt-examples/src/main/
java/edu/umd/cs/piccolox/swt/examples/SWTHelloWorld.java

Committed revision 713.

$ svn mv -m "Issue 132 ; refactoring SWT examples from examples module to new
swt-examples module, commit 3 of several"
https://piccolo2d.googlecode.com/svn/piccolo2d.java/trunk/examples/src/main/java
/edu/umd/cs/piccolo/examples/swt/SWTBasicExample.java
https://piccolo2d.googlecode.com/svn/piccolo2d.java/trunk/swt-examples/src/main/
java/edu/umd/cs/piccolox/swt/examples/SWTBasicExample.java

Committed revision 714.

$ svn mv -m "Issue 132 ; refactoring SWT examples from examples module to new
swt-examples module, commit 4 of several"
https://piccolo2d.googlecode.com/svn/piccolo2d.java/trunk/examples/src/main/java
/edu/umd/cs/piccolo/examples/swt/SWTBenchTest.java
https://piccolo2d.googlecode.com/svn/piccolo2d.java/trunk/swt-examples/src/main/
java/edu/umd/cs/piccolox/swt/examples/SWTBenchTest.java

Committed revision 715.

$ svn commit -m "Issue 132 ; refactoring SWT examples from examples module to 
new
swt-examples module, commit 5 of several" swt-examples/src/main/resources
Adding         swt-examples/src/main/resources
Adding         swt-examples/src/main/resources/edu
Adding         swt-examples/src/main/resources/edu/umd
Adding         swt-examples/src/main/resources/edu/umd/cs
Adding         swt-examples/src/main/resources/edu/umd/cs/piccolox
Adding         swt-examples/src/main/resources/edu/umd/cs/piccolox/swt
Adding         swt-examples/src/main/resources/edu/umd/cs/piccolox/swt/examples

Committed revision 716.

$ svn mv -m "Issue 132 ; refactoring SWT examples from examples module to new
swt-examples module, commit 6 of several"
https://piccolo2d.googlecode.com/svn/piccolo2d.java/trunk/examples/src/main/java
/edu/umd/cs/piccolo/examples/swt/bitmask.gif
https://piccolo2d.googlecode.com/svn/piccolo2d.java/trunk/swt-examples/src/main/
resources/edu/umd/cs/piccolox/swt/examples/bitmask.gif

Committed revision 717.

$ svn mv -m "Issue 132 ; refactoring SWT examples from examples module to new
swt-examples module, commit 7 of several"
https://piccolo2d.googlecode.com/svn/piccolo2d.java/trunk/examples/src/main/java
/edu/umd/cs/piccolo/examples/swt/opaque.jpg
https://piccolo2d.googlecode.com/svn/piccolo2d.java/trunk/swt-examples/src/main/
resources/edu/umd/cs/piccolox/swt/examples/opaque.jpg

Committed revision 718.

$ svn mv -m "Issue 132 ; refactoring SWT examples from examples module to new
swt-examples module, commit 8 of several"
https://piccolo2d.googlecode.com/svn/piccolo2d.java/trunk/examples/src/main/java
/edu/umd/cs/piccolo/examples/swt/translucent.png
https://piccolo2d.googlecode.com/svn/piccolo2d.java/trunk/swt-examples/src/main/
resources/edu/umd/cs/piccolox/swt/examples/translucent.png

Committed revision 719.

$ svn rm -m "Issue 132 ; refactoring SWT examples from examples module to new
swt-examples module, commit 9 of several"
https://piccolo2d.googlecode.com/svn/piccolo2d.java/trunk/examples/src/main/java
/edu/umd/cs/piccolo/examples/swt

Committed revision 720.

$ svn commit -m "Issue 132 ; refactoring SWT examples from examples module to 
new
swt-examples module, commit 10 of 10" .            Sending        
examples/pom.xml
Transmitting file data .
Committed revision 721.

Original comment by heue...@gmail.com on 15 Oct 2009 at 1:04

Changed state: Started

GoogleCodeExporter commented 9 years ago

$ svn commit -m "Issue 132 ; fixing package names and removing Temp class" 
...
Transmitting file data ...
Committed revision 722.

Marking this issue as Fixed, since the refactoring is basically complete.  The
examples do not run under linux x86_gtk since the SWT dependencies are not 
correct:

$ java -classpath
target/piccolo2d-swt-examples-1.3-SNAPSHOT-jar-with-dependencies.jar
edu.umd.cs.piccolox.swt.examples.SWTBenchTest
Exception in thread "main" java.lang.UnsatisfiedLinkError: no swt-win32-3044 in
java.library.path
        at java.lang.ClassLoader.loadLibrary(ClassLoader.java:1709)
        at java.lang.Runtime.loadLibrary0(Runtime.java:823)
        at java.lang.System.loadLibrary(System.java:1028)
        at org.eclipse.swt.internal.Library.loadLibrary(Library.java:100)
        at org.eclipse.swt.internal.win32.OS.<clinit>(OS.java:18)
        at org.eclipse.swt.widgets.Widget.<clinit>(Widget.java:66)
Could not find the main class: edu.umd.cs.piccolox.swt.examples.SWTBenchTest. 
Program will exit.

Further work on that in Issue 124.

Original comment by heue...@gmail.com on 15 Oct 2009 at 1:34

Changed state: Fixed

GoogleCodeExporter commented 9 years ago

Correction to comment #6, further work on SWT dependency versions in Issue 126.

Original comment by heue...@gmail.com on 15 Oct 2009 at 1:36

GoogleCodeExporter commented 9 years ago

Original comment by mr0...@mro.name on 25 Oct 2009 at 6:44

Changed state: Verified

GoogleCodeArchive / piccolo2d

Refactor SWT examples from examples module to new swt-examples module #132