PSwing components cause full page re-rendering on add/remove operations

[GoogleCodeExporter]

What steps will reproduce the problem?
1. Turn on region debugging
2. Add some PSwing components to a canvas
3. Remove one of the PSwing components

What is the expected output? What do you see instead?
On both addition and removal, the whole canvas will be redrawn, causing
rendering delays for a complicated UI.

Proposed fix:
--- C:/dev/piccolo.java-all/extras/edu/umd/cs/piccolox/pswing/PSwing.java
(revision 7)
+++ C:/dev/piccolo.java-all/extras/edu/umd/cs/piccolox/pswing/PSwing.java
(revision 8)
     private void updateCanvas( PSwingCanvas newCanvas ) {
...
                 reshape();
                 repaint();
-                canvas.invalidate();
-                canvas.revalidate();
-                canvas.repaint();
             }
         }
     }

Original issue reported on code.google.com by steveonjava on 24 Jun 2008 at 7:26

[GoogleCodeExporter]

Original comment by steveonjava on 25 Jun 2008 at 6:35

• Added labels: Milestone-1.3

[GoogleCodeExporter]

Original comment by steveonjava on 2 Jul 2008 at 12:28

• Added labels: Milestone-2.0

[GoogleCodeExporter]

Original comment by steveonjava on 3 Jul 2008 at 5:05

• Added labels: Milestone-1.3

[GoogleCodeExporter]

Committed to trunk.

commit -m "Issue 14 ; removing unnecessary invalidate/revalidate and repaint of
PSwingCanvas"
    Sending       
piccolo2d.java-trunk/extras/src/main/java/edu/umd/cs/piccolox/pswing/PSwing.java
    Transmitting file data ...
    Committed revision 392.

Original comment by heue...@gmail.com on 7 Oct 2008 at 8:06

• Changed state: Fixed

[GoogleCodeExporter]

Fix causes only dirty region to bubble up to the top.

Original comment by allain.lalonde on 5 Nov 2009 at 4:41

• Changed state: Verified