search

GoogleCodeArchive / piccolo2d

Automatically exported from code.google.com/p/piccolo2d
0 stars 0 forks source link

Patch: Proper Shape and Text Support in the SWT Part #70

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
Hello,

attached you'll find a patch which adds proper shape support to Piccolo's
SWT package. It no longer uses the polyline workaround for unknown shapes
but SWT's Path class to draw the shapes. In addition, the text
transformation is no longer done inside Piccolo but using the SWT transform
feature (this is also used for the shape support). Further more PSWTText
now supports the transparent text mode.

The patch is against trunk. In general, I think analogous to the Text
transformation change, all other drawing function could hand out the
manually transformation to SWT. But this should be done step by step.

Bye,
Sebastian

Original issue reported on code.google.com by dimweth...@gmail.com on 7 Nov 2008 at 12:35

Attachments:

GoogleCodeExporter commented 9 years ago

Original comment by heue...@gmail.com on 16 Mar 2009 at 6:00

GoogleCodeExporter commented 9 years ago

Original comment by heue...@gmail.com on 15 May 2009 at 6:40

GoogleCodeExporter commented 9 years ago 
I will be applying this patch soon. I'll have to go through it manually since 
the
code has changed since the patch was generated. Yippee. At least I'll get 
familiar
with it.

Original comment by allain.lalonde on 14 Oct 2009 at 9:27

GoogleCodeExporter commented 9 years ago

Original comment by heue...@gmail.com on 14 Oct 2009 at 9:44

GoogleCodeExporter commented 9 years ago 
I've hand applied the patch and find that it requires SWT minimum 3.1 (though I
haven't tested this). Before this change can be moved on we need to up the 
version on
the SWT to at least 3.1.

Attached is the a newly generated patch.

Original comment by allain.lalonde on 15 Oct 2009 at 1:46

Attachments:

GoogleCodeExporter commented 9 years ago 
After applying the patch from Issue 126 and adding a profile for my x86 linux 
32 bit
machine, I was able to compile things but there seems to be background paint 
issues. 

Both the benchmark example and the basic example have "interesting" repaint 
issues.

Regardless, I've regenerated the patch and attached it.

Original comment by allain.lalonde on 15 Oct 2009 at 2:41

Attachments:

GoogleCodeExporter commented 9 years ago 
Changing the "DEFAULT_IS_TRANSPARENT" constant to true from false, fixed the
"problem" with background colours.

Seems that it retains the last paint colour when painting its background.

Original comment by allain.lalonde on 15 Oct 2009 at 2:55

GoogleCodeExporter commented 9 years ago 
I committed r724 for Issue 126, so go ahead when ready.

Original comment by heue...@gmail.com on 15 Oct 2009 at 3:25

GoogleCodeExporter commented 9 years ago 
Patches applied in r727. Please Verify.

Original comment by allain.lalonde on 15 Oct 2009 at 1:50

GoogleCodeExporter commented 9 years ago 
Works for me on platforms supported by the fix in Issue 126.

Original comment by heue...@gmail.com on 21 Oct 2009 at 2:39