PSwing are fuzzy when scale!=1, due to buffering of the PSwing

[GoogleCodeExporter]

What steps will reproduce the problem?
1. Running TestPSwing and setting pCanvas.getLayer().scale(0.98); after
creation of the PSwingCanvas
2. Using the PSwing-nobuffer.java (see attached) resolves the problem

See attached images for the buffered and unbuffered versions.

Original issue reported on code.google.com by samrr...@gmail.com on 7 May 2009 at 8:36

Attachments:

• buffered.png
• unbuffered.png
• PSwing-nobuffer.java

[GoogleCodeExporter]

Original comment by heue...@gmail.com on 15 May 2009 at 6:33

• Added labels: Type-Defect, Priority-High, Component-Extras, Milestone-1.3, Toolkit-Piccolo2D.Java

[GoogleCodeExporter]

Original comment by heue...@gmail.com on 15 May 2009 at 6:38

• Added labels: Priority-Medium
• Removed labels: Priority-High

[GoogleCodeExporter]

Original comment by heue...@gmail.com on 15 May 2009 at 7:49

• Changed state: Accepted

[GoogleCodeExporter]

If there's no good reason for having the buffering in PSwing, I can't see why 
it's
not taken out.

If no-one has objections, I'll take the buffering code and take it out, or at 
least
make it optional.

Original comment by allain.lalonde on 14 Jul 2009 at 5:19

[GoogleCodeExporter]

My team and I tried removing buffering from PSwing; however, it caused a 
problem that
some swing components (buttons, labels, etc) rendered with a '...' on Mac.  
That is,
instead of a button reading "Press Me", on a Mac, some unbuffered PSwings would 
read
something like "Press M...".  So we have re-enabled buffering in PSwing in our 
local
copy and recommend not disabling buffering until this problem is resolved.

Original comment by samrr...@gmail.com on 14 Jul 2009 at 5:22

[GoogleCodeExporter]

Allain, 
I paste your code snippt here where I can link to and set ma a reminder (and 
still
getting my inbox clear):

I'll try out the following code snippet within the next week:

  public void paint(Graphics2D g2) {
       if (component.getBounds().isEmpty()) {
           // The component has not been initialized yet.
           return;
       }

       PSwingRepaintManager manager = (PSwingRepaintManager)
RepaintManager.currentManager(component);
       manager.lockRepaint(component);

       RenderingHints oldHints = g2.getRenderingHints();

       g2.setRenderingHint(RenderingHints.KEY_FRACTIONALMETRICS,

RenderingHints.VALUE_FRACTIONALMETRICS_OFF);
       component.paint(g2);

       g2.setRenderingHints(oldHints);

       manager.unlockRepaint(component);
   }

Original comment by mr0...@mro.name on 14 Jul 2009 at 3:11

[GoogleCodeExporter]

oh, my tyginp - a mess!

Original comment by mr0...@mro.name on 14 Jul 2009 at 3:13

[GoogleCodeExporter]

tyginp? not following.

Original comment by allain.lalonde on 14 Jul 2009 at 3:21

[GoogleCodeExporter]

Oh, just got it. no worries.

Original comment by allain.lalonde on 14 Jul 2009 at 3:22

[GoogleCodeExporter]

Received Email confirmation from Chris Malley and permission to push by Samuel.

Original comment by allain.lalonde on 14 Jul 2009 at 8:33

[GoogleCodeExporter]

Should probably get confirmation from a couple more mac users before declaring 
this one 
dead.

Original comment by allain.lalonde on 14 Jul 2009 at 8:38

• Changed state: Fixed

[GoogleCodeExporter]

Sorry, forgot to put in the revision that fixed it: r467

Original comment by allain.lalonde on 14 Jul 2009 at 8:39

[GoogleCodeExporter]

Seems that the fractional font metrics are required for smooth zooming on 
windows. Can 
someone with a mac tell us if the text "jumps" from one font size to another 
when 
zooming rather than smoothly transitioning.

I'm re-opening it since there are problems with the windows controls now if the 
fractional fonts are disallowed.

Original comment by allain.lalonde on 16 Jul 2009 at 1:53

• Changed state: Started

[GoogleCodeExporter]

Honestly - I don't get how to try this out - there's no demonstrating class in 
the
project yet, right?

Original comment by mr0...@mro.name on 18 Jul 2009 at 1:04

[GoogleCodeExporter]

PSwingExample1 in the examples project would do.

Original comment by allain.lalonde on 18 Jul 2009 at 1:23

[GoogleCodeExporter]

great, I added a 

        pCanvas.getCamera().scale(0.98f);

at line 171 - the result looks great to me. Shots attached.

Original comment by mr0...@mro.name on 18 Jul 2009 at 2:10

Attachments:

• PSwingExample1-scale-100.png
• PSwingExample1-scale-098.png

[GoogleCodeExporter]

While zooming the whole display content flickers a bit and the text placement 
seems
to hop sometimes - but not more than one pixel as far as i can see.

I'd record a screencast, but don't know how to do that.

Altogether the result looks well acceptable to me.

Tested on a macbook, OS X 10.5.7, 
$ java -version
java version "1.5.0_19"
Java(TM) 2 Runtime Environment, Standard Edition (build 1.5.0_19-b02-304)
Java HotSpot(TM) Client VM (build 1.5.0_19-137, mixed mode, sharing)

Original comment by mr0...@mro.name on 18 Jul 2009 at 3:16

[GoogleCodeExporter]

Fixed in r550 (hopefully for the last time... grumble grumble)

Original comment by allain.lalonde on 23 Jul 2009 at 3:43

[GoogleCodeExporter]

Original comment by allain.lalonde on 4 Aug 2009 at 1:31

• Changed state: Fixed

[GoogleCodeExporter]

Original comment by heue...@gmail.com on 21 Oct 2009 at 2:43

• Changed state: Verified

[GoogleCodeExporter]

Re-opening due to recent rollback

Original comment by allain.lalonde on 23 Oct 2009 at 9:40

• Changed state: Accepted

[GoogleCodeExporter]

Fixed in revision 863.

Original comment by allain.lalonde on 29 Oct 2009 at 9:10

[GoogleCodeExporter]

Original comment by allain.lalonde on 29 Oct 2009 at 9:10

• Changed state: Fixed

[GoogleCodeExporter]

Looks good to me on Mac OSX 10.5.8 PPC

$ java -version
java version "1.5.0_20"
Java(TM) 2 Runtime Environment, Standard Edition (build 1.5.0_20-b02-315)
Java HotSpot(TM) Client VM (build 1.5.0_20-141, mixed mode, sharing)

Original comment by heue...@gmail.com on 4 Nov 2009 at 7:46

• Changed state: Verified