GoogleCodeArchive / piccolo2d

Automatically exported from code.google.com/p/piccolo2d
0 stars 0 forks source link

inconsistencies of position method in PNode #86

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
The position method of PNode is the only animation function that doesn't 
begin with the word animate.  Also, it doesn't return a PAcvitity instance, 
making it rather difficult to test.

I've attached a patch that renames is animateToRelativePosition and makes it 
return a PActivity.  With said activity I was able to write a little test 
that bumped PNode's coverage up to 51.5% from 46.7%.

Original issue reported on code.google.com by allain.lalonde on 10 Jul 2009 at 11:35

Attachments:

GoogleCodeExporter commented 9 years ago
This seems reasonable to me, but should happen in a later version.  position 
should
be marked as deprecated for at least one release.

Original comment by heue...@gmail.com on 13 Jul 2009 at 2:46

GoogleCodeExporter commented 9 years ago
This change has been incorporated into the code base already, position is still
around, just marked as deprecated and it delegates to animateToRelativePosition

Original comment by allain.lalonde on 14 Jul 2009 at 3:13